Fixing bug in backward-in-time-writing

OceanParcels / Parcels

Main code for Parcels (Probably A Really Computationally Efficient Lagrangian Simulator)

https://www.oceanparcels.org

MIT License

297 stars 138 forks source link

Fixing bug in backward-in-time-writing #1723

Closed erikvansebille closed 1 month ago

erikvansebille commented 1 month ago

This fixes #1722, by reverting a change in ed11e43

Thanks for the git-bisect hint, @VeckoTheGecko!

VeckoTheGecko commented 1 month ago

I think we can benefit with a refactor of pset.execute() and more rigorous testing of it. That will be a focus for me, and we can roll that into the next minor release.

We plan to do a patch release where the only difference from v3.0.5 is fixing this bug. Plan:

[x] Isolate this patch into new branch and create release
[x] Yank v3.0.5 from conda/pypi (pypi is done, request submitted for conda)