Closed michaeldenes closed 1 month ago
Attention: Patch coverage is 0%
with 14 lines
in your changes are missing coverage. Please review.
Project coverage is 15.43%. Comparing base (
7664fd0
) to head (fff5309
).
Files | Patch % | Lines |
---|---|---|
plasticparcels/constructors.py | 0.00% | 14 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@erikvansebille , the paper is now in a final draft form (downloadable via the actions tab above).
The only things I can think of are: a) should we include more references for the line '... users can perform Lagrangian simulations of a wide variety of particulates, such as tuna, plastic, plankton, icebergs, turtles...'? b) can we remove some of the code in the usage example, and just link to the tutorial and show the plots?
EDIT: and c) dealing with the Copernicus Marine Service reference, what should we reference here?
@erikvansebille a last double check review before we release a new version and submit?
@erikvansebille a last double check review before we release a new version and submit?
Yep, I'll check now
This PR is to improve the documentation of
plasticparcels
. Currently a lot of information is missing, specifically the required datasets, and some information on the kernels and initialisation maps.