codecov-commenter
commented
1 month ago Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.
Project coverage is 15.33%. Comparing base (
fe32c0b) to head (d1d20d4).
| Files | Patch % | Lines |
|---|---|---|
| plasticparcels/constructors.py | 0.00% | 3 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #34 +/- ## ========================================== - Coverage 15.43% 15.33% -0.10% ========================================== Files 6 6 Lines 473 476 +3 ========================================== Hits 73 73 - Misses 400 403 +3 ``` | [Flag](https://app.codecov.io/gh/OceanParcels/plasticparcels/pull/34/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanParcels) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/OceanParcels/plasticparcels/pull/34/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanParcels) | `15.33% <0.00%> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OceanParcels#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a PR that changes the way we initialise particles, rather than one particle at the T-point of a grid cell, we will initialise n particles randomly within a grid cell.
create_release_maps.pyfile is working as expectedcreate_particleset_from_map()function inconstructorsto use the grid cellsPoint 2 above is non-trivial, as we want to randomly distribute particle across the grid cell. Trivial for a rectilinear grid, but non-trivial for our curvilinear grid. Possible approach is to perform a rotation (like the Jacobian approach in the interpolation scheme?)