add access control to service level - Githubissues

OceanProtocolEnterprise / ocean-node

Apache License 2.0

0 stars 1 forks source link

add access control to service level #12

Closed FilipMasar closed 4 months ago

FilipMasar commented 6 months ago

Fixes #7

Changes proposed in this PR:

add credentials field in Service
check service credentials in download task
tests
- unit tests were already implemented here
- new integration test
- new util file with ganachePrivateKeys to better understand from where some random strings comes from

Notes

I am returning httpStatus: 500 since that was returned also on asset level. But maybe it would be better to use different code - e.g. 403?
I implemented integration test from already existed /integration/download.test.ts test. There are many bugs in that file resulting in test passing even though they should not. E.g. here it is missing await. I created an issue in the original repo

FilipMasar commented 5 months ago

@alexcos20 tests are done. Please have a look. I updated the PR description.