Closed simedroniraluca closed 11 months ago
We only have clear info about the EK80 for waveform_mode
and encode_mode
. So, I'm only setting rules for EK80. Check the documentation here. We're not totally sure if all EK60 types use the same settings for these parameters.
Because all EK60 echosounders are narrowband devices, they will all use "CW" and "power"
Because of the phrases emphasized in the image below, taken from echopype documentation for computing Sv, I do not add checks on other instruments besides EK80. We do not know everything about all types of EK60. We will use our assumption that "For EK60: While these parameters can be present, they have a fixed configuration of waveform_mode='CW' and encode_mode='power', but not in checks.
Fixed
The current implementation of
compute_sv()
requires that the optional parameterswaveform_mode
andencode_mode
appear exclusively for EK80. However, this behavior is not entirely correct.Expected Behavior:
waveform_mode
andencode_mode
are required.waveform_mode="CW"
andencode_mode="power"
.Current Behavior: The function raises an error if
waveform_mode
andencode_mode
are present for EK60, even if they have the correct configuration.Suggested Fix: Update the checks in
compute_sv()
to account for the possibility of these parameters being present in the EK60 case with the previously mentioned configuration.