Oceankoh / pe

0 stars 0 forks source link

Overly restrictive validation on phone numbers #3

Open Oceankoh opened 1 week ago

Oceankoh commented 1 week ago

While phone numbers greater than 8 numbers is included as a planned enhancement, it might also be useful to allow characters like + for country codes, and () for phone number extensions.

image.png

soc-pe-bot commented 1 week ago

Team's Response

This is very similar to #3699.

It is good that you point out that our limitation of phone numbers is too strict.

We have decided on the future enhancement that we are not limiting the phone number to 8 digits in favor of overseas students and other special cases. It is a planned feature for the future and not in the scope of the current delivery.

Thank you for the suggestion anyway, we will implement in the future.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** This issue cannot be fixed by means of documentation. Documenting it might make users more aware of the restrictions, however, the limitation would still exist in the app.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** A `severity.VeryLow` is for cosmetic flaws which does not affect usage. ![image.png](https://raw.githubusercontent.com/Oceankoh/pe/main/files/ca610984-192a-47a0-bf76-75bf19c6dc46.png) Given that the team has acknowledge that the issue valid but `response.NotInScope`, it implies that it is not a cosmetic issue. > It is a planned feature for the future and not in the scope of the current delivery. The severity should be `severity.Low` instead. ![image.png](https://raw.githubusercontent.com/Oceankoh/pe/main/files/79aaf55c-7c0f-48e7-bf80-d8b6b5ec27ca.png)