Open Tirokk opened 3 years ago
@Tirokk I can take this issue up, if it is available.
Hey @akshajb ,
yes for sure you can take over. That’s great! 🤗 I assigned you to this issue.
I cared for your invitation to our community as volunteer via an e-mail invitation you can accept.
Our conversation runs over our discord server: https://discord.gg/AJSX9DCSUA There we have usually from Monday to Thursday a Daily Standup at UTC 09:30 am (CEST 11:30 am) in the Office Cube.
Please don’t compare from your fork to this repository, in case, because the publish action will fail, because of permission problems with the credentials.
Just push your branch
Hey @Tirokk
This might sound a little "nooby", but do you want me to fork the repo, create a branch , push and create a PR or is there another process you would like me to follow.
Hey @akshajb .
Don’t hesitate to ask every question. there are no stupid ones.
You don’t need a fork.
Clone this repo locally, create your branch named <issue-number+description>, add your code, and push this branch to this repo plus create a PR by comparing to our master
.
To have the necessary permission, please accept my invitation to our volunteers team via the e-mail I send to you. 🤗
Hey @Tirokk I was quite busy last 2 weeks. will try my best to finish this issue tomorrow.
Hey @Tirokk I am using WSL2, and I am able to run docker-compose up
, However, I am not able to run the storybook command for docker.
I get the following error
Hey @akshajb ,
$ docker-compose up
Has to run in one terminal while you run:
# in main folder while docker-compose is up
$ docker-compose exec webapp yarn storybook
… in an other terminal in the main folder as well.
Alternatively you can run all locally, see https://github.com/Ocelot-Social-Community/Ocelot-Social/blob/Tirokk-change-readme-db-commands-for-docker/README.md#local-installation . Or https://github.com/Ocelot-Social-Community/Ocelot-Social/blob/master/SUMMARY.md
Any problems by working on this issue? @akshajb
PS: No pressure, just try to help …
@Tirokk hey thank you for checking in . I have been busy, switching jobs, so i have not been able to spend time on it, I will do so this weekend
Hey @akshajb ,
$ docker-compose up
Has to run in one terminal while you run:
# in main folder while docker-compose is up $ docker-compose exec webapp yarn storybook
… in an other terminal in the main folder as well.
Alternatively you can run all locally, see https://github.com/Ocelot-Social-Community/Ocelot-Social/blob/Tirokk-change-readme-db-commands-for-docker/README.md#local-installation . Or https://github.com/Ocelot-Social-Community/Ocelot-Social/blob/master/SUMMARY.md
Hey @akshajb ,
In case you are working on Windows we recommend to use Docker only for the database: See issue #4793
And I've learned that the StoryBook only works locally in the webapp folder terminal and not with Docker:
# in webapp folder
# once
$ yarn
# then always
$ yarn storybook
If you need any help if you start working then let me know …
@Tirokk I might resolve this issue but just need some detail that what you exactly want.
@mud1tx like I wrote in #6189 this ticket could be interesting!
:rocket: Feature Request
If one clicks on the link in the password change e-mail the included nonce should be displayed on the network page.
Example link from the e-mail: https://wir.social/password-reset/change-password?nonce=0a9fc5&email=user%40example.org
Design
You can find a similar displaying of already entered data in the registration. Have a look into the registration slider you can run via our storybook.
You can then visit the Storybook playground on
http://localhost:3002
Todo
Create a story in the storybook if not there already.