OcelotProject / Ocelot

Ocelot is open-source linking for life cycle assessment. See https://ocelot.space/ for more information.
Other
25 stars 7 forks source link

Chinese cotton links to RoW low voltage electricity supplier #119

Closed mfastudillo closed 5 years ago

mfastudillo commented 7 years ago

Hello hello

I have noticed something a bit strange. using the default system model, some datasets seem not to link to the right market. I tested it for Chinese cotton, and for some reason it uses RoW low voltage electricity instead of the Chinese one. The allocated datasets provided by ecoinvent do link to the Chinese electricity market.

I am using the unlinked version of ecoinvent given during the ocelot workshop, that could be the reason of the strange linking behaviour. Attached a cumbersome notebook to test this.

Miguel

ocelot_test_linking.pdf

cmutel commented 7 years ago

TLDR: This needs #100 to be fixed.

Ecoinvent provides markets for the China Southern power grid and the State Grid Corporation of China, and a market group for all of China. Because we haven't got around to implementing market groups yet, the cotton process needs to consume from a market which completely covers the location CN, which neither grid does - therefore it defaults to RoW. When #100 is closed, the market group for low voltage electricity in China will be available, and will be linked correctly, as it is in the ecoinvent release.

cmutel commented 5 years ago

Will close this when #100 is also closed.

cmutel commented 5 years ago

Fixed in 04a71515ff428b598e223fadceb829d6314f89ed. However, more work needs to be done before this branch is merged. See commit message.