search

OcelotProject / Ocelot

Ocelot is open-source linking for life cycle assessment. See https://ocelot.space/ for more information.
Other
25 stars 7 forks source link

Production volume subtracted due to activity links doesn't get subtracted from the corresponding global volume #92

Closed pjamesjoyce closed 5 years ago

pjamesjoyce commented 8 years ago

The add_hard_linked_production_volumes function (in transformations.activity_links) adds 'subtracted activity link volume' to transformation functions that are activity linked to other processes, but doesn't change the production volume of the corresponding GLO. When the GLO later gets converted to RoW, this leads to overrepresentation of RoW in the market, as it retains its original production volume. For stuff like aluminium, this could be a problem.

cmutel commented 5 years ago

This is still incorrect. See #147; the PV of the RoW is 4 - (RER original PV - activity link), but it should be should be 4 - (RER original PV).

cmutel commented 5 years ago

Fixed in #154.