OcelotProject / Ocelot

Ocelot is open-source linking for life cycle assessment. See https://ocelot.space/ for more information.
Other
25 stars 7 forks source link

PVs without variable names not being recalculated #94

Closed PascalLesage closed 8 years ago

PascalLesage commented 8 years ago

Production volumes without variable names are not being recalculated. However:

PVs without variable names need to be recalculated.

The current number of PVs without variable names that depend on formulas is 8459.

This was determined with:

list_production_volumes_without_variable_names_using_formulas = []
for ds in pre_data:
    for exc in ds['exchanges']:
        pv = exc.get('production volume')
        if pv and pv.get('formula') and not pv.get('variable'):
                list_production_volumes_without_variable_names_using_formulas.append((ds['name'], exc['name']))
len(list_production_volumes_without_variable_names_using_formulas)
PascalLesage commented 8 years ago

This was wrong. PVs without variable names are included via iterate_all_parameters(dataset) in recalculate_sample.