Ocramius / ChangeSet

:vhs: A simple changeset list that supports operations like insert/update/delete, event triggering, commits and rollbacks
MIT License
68 stars 9 forks source link

[WIP] Pimple, Interfaces #5

Closed liuggio closed 11 years ago

liuggio commented 11 years ago

I didn't change so much, I added an Abstract Repository, a simple Associator for class->worker, and few Interfaces

let me know what do you think, thanks to the interfaces I created a stupid orm.

Ocramius commented 11 years ago

@liuggio I generally like the changes, but don't try to specialize the factories or make them smarter for now. The demos are supposed to work with only stdClass, and the factories should be completely replaced by a consuming library configuring a micro-DIC that provides all these components.

coveralls commented 11 years ago

Coverage Status

Coverage decreased (-0%) when pulling 9d6c57827a4dfed9038825b2d33a941c8a8ab764 on liuggio:master into 782620bfbb93b222b92ad2dbb553bcdf7dd5bcac on Ocramius:master.

liuggio commented 11 years ago

totally agree with you I see now the future :)

Ocramius commented 11 years ago

@liuggio can you remove the associator stuff then? :)

liuggio commented 11 years ago

Yep!

On Wed, Jun 26, 2013 at 5:48 PM, Marco Pivetta notifications@github.comwrote:

@liuggio https://github.com/liuggio can you remove the associator stuff then? :)

— Reply to this email directly or view it on GitHubhttps://github.com/Ocramius/ChangeSet/pull/5#issuecomment-20057888 .

__liuggio_____

/|_ We reject kings, presidents and voting. /o ) \/ We believe in rough consensus ) v _/\ and running code (I.E.T.F. credo)


liuggio commented 11 years ago

Ok think about it as super WIP, I made this in half an hour and I'm in hurry (sorry) don't hate me, I added Pimple, and few containers, I'd like to change the names, and I removed the ObjectLoaderFactory only because I didn't not understand his objective.

liuggio commented 11 years ago

If you think that Pimple is not necessesary I'll remove it leaving only the repo and the 2 interfaces..

coveralls commented 11 years ago

Coverage Status

Coverage decreased (-0%) when pulling 1e7040b05d93429a118cf4dc0a17a579d887e77c on liuggio:master into 782620bfbb93b222b92ad2dbb553bcdf7dd5bcac on Ocramius:master.

coveralls commented 11 years ago

Coverage Status

Coverage decreased (-0%) when pulling 05da51aa634b7eb25fb88fd76944d5c617aa59a8 on liuggio:master into db04fc86a25fcd4c030e15183c9aa75ee07b9601 on Ocramius:master.

coveralls commented 11 years ago

Coverage Status

Coverage decreased (-0%) when pulling 840bf70845d0548e2e0b9a7222f9094d58358f66 on liuggio:master into db04fc86a25fcd4c030e15183c9aa75ee07b9601 on Ocramius:master.

liuggio commented 11 years ago

Little recap:

coveralls commented 11 years ago

Coverage Status

Coverage decreased (-0%) when pulling feb324ae13963c7e38eeddc0da63f643909a8fcc on liuggio:master into db04fc86a25fcd4c030e15183c9aa75ee07b9601 on Ocramius:master.

Ocramius commented 11 years ago

Merging - hopefully going on with this tomorrow (I will try to integrate it with the existing ORM ;) )

Ocramius commented 11 years ago

And obviously: thanks!