search

Ocramius / PackageVersions

:package: Composer addon to efficiently get installed packages' version numbers
MIT License
3.22k stars 67 forks source link

Fix incorrect lookup path for `installed.json` #113

Closed arondeparon closed 4 years ago

arondeparon commented 4 years ago

This fixes the issue that cause Laravel installations with a dependency on 1.4.x to break that are installed using composer install --no-scripts as described in #112

Ocramius commented 4 years ago

Hey @ArondeParon, please also backport the tests :S

My suggestion is to use git cherry-pick rather than copy-pasting the diff

arondeparon commented 4 years ago

Will do! I did not see the backport yet and wrote the exact same fix as you already did 😉

Ocramius commented 4 years ago

@ArondeParon about 03e5174, I think master should stay with the current branch-alias, but the test should allow for \d+ as a start of the version string, rather than 1: https://travis-ci.org/Ocramius/PackageVersions/jobs/612436287#L335

arondeparon commented 4 years ago

@Ocramius yeah I was not entirely sure about how you would like to see it, but noticed that dev-master pointed to the most current branch and 2.x did not exist.

I'll change the test to be a bit more flexible 👌

arondeparon commented 4 years ago

Tests passing now 😃

Ocramius commented 4 years ago

LGTM! :+1: