Ocramius / PackageVersions

:package: Composer addon to efficiently get installed packages' version numbers
MIT License
3.22k stars 67 forks source link

Packages don't always have a source/reference #12

Closed Ocramius closed 8 years ago

Ocramius commented 8 years ago

Moved from https://github.com/Ocramius/ProxyManager/issues/294

Basically, when using something like following:

{
    "require": {
        "jquery/jquery":  "1.10.*"
    },
    "repositories": [
        {
            "type": "package",
            "package": {
                "name": "jquery/jquery",
                "version": "1.10.2",
                "dist": {
                    "url": "http://code.jquery.com/jquery-1.10.2.js",
                    "type": "file"
                }
            }
        }
    ]
}

As you can see, this package has no source reference, as it comes from a repository (in-lined in the composer.json) that has no such information. Therefore, this call fails, causing a general failure of the code generation in the script.

magnetik commented 8 years ago

yay ! Do you mind tagging a new version (in the 1.x branch)?

Ocramius commented 8 years ago

@magnetik yarp, gonna happen now.

Ocramius commented 8 years ago

@magnetik released

magnetik commented 8 years ago

Awesome, thanks !