search

Ocramius / PackageVersions

:package: Composer addon to efficiently get installed packages' version numbers
MIT License
3.22k stars 67 forks source link

Broken composer after update #134

Closed millsoft closed 4 years ago

millsoft commented 4 years ago

Hi,

today I performed a composer update and some libraries were also requiring PackageVersions. After the install I can't use composer anymore. If I execute composer I get this:

PHP Parse error:  syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /home/michael/Dev/twm/vendor/ocramius/package-versions/src/PackageVersions/Installer.php on line 34

I am using php 7.3:

╰─ php --version
PHP 7.3.11-0ubuntu0.19.10.3 (cli) (built: Feb 12 2020 15:22:33) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.11, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.3.11-0ubuntu0.19.10.3, Copyright (c) 1999-2018, by Zend Technologies

Composer:

Composer version 1.9.2 2020-01-14 16:30:31

I tried this on multiple machines with similar configuration (all with php 7.3) To downgrade I need to remove the vendor directory, revert previous composer.lock and do a composer install.

the dependency tree is:

Ocramius commented 4 years ago

Potentially duplicate of #105

On Fri, Apr 3, 2020, 20:54 Michael M notifications@github.com wrote:

Hi,

today I performed a composer update and some libraries were also requiring PackageVersions. After the install I can't use composer anymore. If I execute composer I get this:

PHP Parse error: syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /home/michael/Dev/twm/vendor/ocramius/package-versions/src/PackageVersions/Installer.php on line 34

I am using php 7.3:

╰─ php --version

PHP 7.3.11-0ubuntu0.19.10.3 (cli) (built: Feb 12 2020 15:22:33) ( NTS )

Copyright (c) 1997-2018 The PHP Group

Zend Engine v3.3.11, Copyright (c) 1998-2018 Zend Technologies

with Zend OPcache v7.3.11-0ubuntu0.19.10.3, Copyright (c) 1999-2018, by Zend Technologies

Composer:

Composer version 1.9.2 2020-01-14 16:30:31

I tried this on multiple machines with similar configuration (all with php 7.3) To downgrade I need to remove the vendor directory, revert previous composer.lock and do a composer install.

the dependency tree is:

  • sentry/sentry
    • jean85/pretty-package-versions
      • ocramius/package-versions

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Ocramius/PackageVersions/issues/134, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABFVEBYCQMRFXECPK4Q2SLRKYWGDANCNFSM4L4LZHKQ .

Ocramius commented 4 years ago

Yep, indeed a duplicate of #105 - the fact that you managed to install ocramius/package-versions on a PHP 7.3 system indicates that you probably used --ignore-platform-reqs.

flack commented 4 years ago

the same happened to me today in Symfony Insight:

https://insight.symfony.com/projects/90006b57-00fb-41c8-a4f0-18cbbfdf6305/analyses/766?status=violations#850409792

in your opinion, is this a configuration error on their end (I use their default configuration, whatever that might be)? I find it hard to believe that they would use --ignore-platform-reqs, especially since there was never any problem related to that so far, but who knows..

Ocramius commented 4 years ago

Yeah, needs fixing on that end: installing without platform requirements is asking for trouble in general.

On Mon, Apr 6, 2020, 23:10 flack notifications@github.com wrote:

the same happened to me today in Symfony Insight:

https://insight.symfony.com/projects/90006b57-00fb-41c8-a4f0-18cbbfdf6305/analyses/766?status=violations#850409792

in your opinion, is this a configuration error on their end (I use their default configuration, whatever that might be)? I find it hard to believe that they would use --ignore-platform-reqs, especially since there was never any problem related to that so far, but who knows..

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Ocramius/PackageVersions/issues/134#issuecomment-610038211, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABFVEEHO643F27WBGIELHTRLJAKTANCNFSM4L4LZHKQ .