search

Ocramius / PackageVersions

:package: Composer addon to efficiently get installed packages' version numbers
MIT License
3.22k stars 67 forks source link

"replace" composer/package-versions-deprecated v1 #158

Closed nicolas-grekas closed 4 years ago

nicolas-grekas commented 4 years ago

composer/package-versions-deprecated doesn't need a v2. Instead, when a package requires composer/package-versions-deprecated v1, but ocramius/package-versions v2 is also required, it should replace the fork from composer.

Makes sense?

/cc @Seldaek FYI

Ocramius commented 4 years ago

I don't know how a double-replace works here :thinking:

nicolas-grekas commented 4 years ago

I don't know how a double-replace works here thinking

yep, @Seldaek WDYT?

The alternative is of course to ship a v2 of composer/package-versions-deprecated that replaces ocramius/package-versions v2.

But I'd better do something else with my OSS time than care about this situation, ideally.

Seldaek commented 4 years ago

This is really not an API-safe replacement, so strictly speaking adding that replace is wrong and might break things. Aside from that I think it shouldn't cause issues but can't say that I tried this before.

nicolas-grekas commented 4 years ago

We then need composer/package-versions-deprecated v2. Maybe it could just be a metapackage that requires ocramius/package-version v2 🤔

nicolas-grekas commented 4 years ago

Or maybe not since that would reintroduce the issue with PHP < 7.4...