search

Ocramius / PackageVersions

:package: Composer addon to efficiently get installed packages' version numbers
MIT License
3.22k stars 67 forks source link

Fix for #18 - support running with --no-scripts flag #33

Closed Ocramius closed 8 years ago

Ocramius commented 8 years ago

Provides fix for #18

nikolaposa commented 8 years ago

And what about some totally different approach of triggering Installer at certain event (autoloading?), or at least lazy loading (replacing) this dynamic Versions class after getVersion() is invoked for the first time?

Ocramius commented 8 years ago

And what about some totally different approach of triggering Installer at certain event (autoloading?)

Assuming read-only FS for vendor after deployment. Otherwise, we introduce possible security issues. I simply want to allow usage for people running with --no-scripts, but I don't really care if they have a performance impact then: their problem for not optimizing at install-time.

Ocramius commented 8 years ago

Alright, this goes in and I will make a release :-)

stof commented 8 years ago

There is a big drawback in this PR: it means that a normal install will leave the package in a dirty state, which will cause issues on next updates for people installing from source

Ocramius commented 8 years ago

@stof yeh, no real way around it, for now :-\