Ocramius / PackageVersions

:package: Composer addon to efficiently get installed packages' version numbers
MIT License
3.22k stars 67 forks source link

added docs to Versions::VERSION #81

Closed staabm closed 5 years ago

staabm commented 5 years ago

the constant is public for technical reasons, therefore should be documented as @internal.

Added a hint for the public api to use

staabm commented 5 years ago

lead by my IDEs autocomplete feature I accidentally read from this public array, instead of using the proper API. this mistake on my end resulted in PackageVersions not using the proper Fallback for the --no-scripts case.

staabm commented 5 years ago

should I adjust test expectations or is this something you can do easily?

Ocramius commented 5 years ago

Yeah, test expectations also need adjusting

Ocramius commented 5 years ago

Thanks @staabm!