search

Ocramius / PackageVersions

:package: Composer addon to efficiently get installed packages' version numbers
MIT License
3.22k stars 67 forks source link

updated dependencies #93

Closed staabm closed 5 years ago

staabm commented 5 years ago

I guess this will fix https://github.com/Ocramius/PackageVersions/issues/92

lets see what travis thinks

Ocramius commented 5 years ago

Possibly needs a major version bump in PHPUnit

staabm commented 5 years ago

we cant bump to phpunit8 because that would drop php7.1 support

I guess the only viable solution right now is a "allow-failure" for php7.4 since there is no phpunit version which supports 7.1-7.4 - see https://phpunit.de/supported-versions.html

Ocramius commented 5 years ago

That's fine, since the target for this is 1.5.0

On Tue, Jun 18, 2019, 17:26 Markus Staab notifications@github.com wrote:

we cant bump to phpunit8 because that would drop php7.1 support

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ocramius/PackageVersions/pull/93?email_source=notifications&email_token=AABFVEF3WVJBV4LKGFMC4Z3P3D5CZA5CNFSM4HZAVRE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX7AJIA#issuecomment-503186592, or mute the thread https://github.com/notifications/unsubscribe-auth/AABFVED6OCFEQJMRWD3OVY3P3D5CZANCNFSM4HZAVREQ .

staabm commented 5 years ago

That's fine, since the target for this is 1.5.0

so you mean we should drop php7.1 support and bump to phpunit8?

Ocramius commented 5 years ago

Yep

On Tue, Jun 18, 2019, 17:37 Markus Staab notifications@github.com wrote:

That's fine, since the target for this is 1.5.0

so you mean we should drop php7.1 support and bump to phpunit8?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ocramius/PackageVersions/pull/93?email_source=notifications&email_token=AABFVEGPBAYCDCDZEZNPXRLP3D6LLA5CNFSM4HZAVRE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX7BOMI#issuecomment-503191345, or mute the thread https://github.com/notifications/unsubscribe-auth/AABFVEGVTCDAYLKET4FVMDTP3D6LLANCNFSM4HZAVREQ .

staabm commented 5 years ago

uplifting php to 7.2 will shrink the possible userbase for this lib to ~25% of the actual php ecosystem - see https://seld.be/notes/php-versions-stats-2018-1-edition

I dont like this direction at all and I think its not a step in the correct direction to uplift the min-phpversion while stop to maintain older versions which are the lions share of the market. but at least you got what you asked for ;-).

Ocramius commented 5 years ago

That's what I do to all minor releases of all libraries I write: it is normal and expected. 1.4.x is still very much around

staabm commented 5 years ago

I am aware that you love this kind of "BC policy", but it makes consuming (and relying) on your libs very hard.

most of our products are on ubuntu16 lts boxes and those are stuck on php 7.0 until they get updated to ubuntu20, which is the next planned cycle. even the newer boxes on our end with ubuntu18 just use php 7.2.

dropping php support for this versions that early (while not maintaining previous versions) for a rather new lib like this one which has still some rough edges (e.g. https://github.com/Ocramius/PackageVersions/pull/91) forces us to maintain a fork of this lib which brings back the php 7.0 compat.

Ocramius commented 5 years ago

Which is fine: this has already been done for this library before, but it is also your choice to stick to EOL'd PHP.

On Tue, Jun 18, 2019, 19:36 Markus Staab notifications@github.com wrote:

I am aware that you love this kind of "BC policy", but it makes consuming (and relying) on your libs very hard.

most of our products are on ubuntu16 lts boxes and those are stuck on php 7.0 until they get updated to ubuntu20, which is the next planned cycle. even the newer boxes on our end with ubuntu18 just use php 7.2.

dropping php support for this versions that early (while not maintaining previous versions) for a rather new lib like this one which has still some rough edges (e.g. #91 https://github.com/Ocramius/PackageVersions/pull/91) forces us to maintain a fork of this lib which brings back the php 7.0 compat.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Ocramius/PackageVersions/pull/93?email_source=notifications&email_token=AABFVEH47NL5LJMMUFA4BHLP3EMINA5CNFSM4HZAVRE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX7MPXQ#issuecomment-503236574, or mute the thread https://github.com/notifications/unsubscribe-auth/AABFVEHJ3WCUGNSGQU6UZMDP3EMINANCNFSM4HZAVREQ .

Ocramius commented 5 years ago

In practice: pin to ^1.4.0. if any new features land, then this is an incentive to upgrade overall.

I can also gladly maintain previous versions, but not for free.

staabm commented 5 years ago

Yeah, I see your point... its mostly the freetime for no-money thing, which I can totally agree with