search

OctaneLending / lpconnector

Python client for syncing LastPass Enterprise with a remote directory over LDAP
Apache License 2.0
15 stars 3 forks source link

Readme.rst was incorrect. #7

Closed jpvajda closed 6 years ago

jpvajda commented 6 years ago

I was testing this out and I clarified you need to add a new directory call /config based on the destination path specified in the mv command, and also that the originating .ini file is located in /base/config. I submitted a PR but it looks like it was rejected.

jpvajda commented 6 years ago

screen shot 2018-04-16 at 5 02 55 pm

jixson12 commented 6 years ago

Hey @jpvajda, thanks for reporting! I'll update the Readme and figure out what's up with our contributor settings. We might need to update our contributor guidelines accordingly

jixson12 commented 6 years ago

Hey @jpvajda, I disabled the "Restrict editing to users in teams with push access only" option on the repo, can you verify that you can now create a PR when you get a chance?

jpvajda commented 6 years ago

@jixson12 Still getting an auth error on the PR.

jpvajda commented 6 years ago

You did resolve the problem so no worries on this PR, I'll revert the commit, though perhaps permissions are off on the repo for people to contribute.

jixson12 commented 6 years ago

Yeah, I think we're going to have to add contributors as outside collaborators, can't find any other way to open it up. We'll have to figure out our process for that and reflect it in the contributor guidelines