search

OctoD / godot-gameplay-systems

⚔️ A plugin for Godot to create your gameplay systems in a Godot way.
MIT License
509 stars 49 forks source link

🐛 [bug] #15

Closed AntonioJose-OcachoGames closed 1 year ago

AntonioJose-OcachoGames commented 1 year ago

Describe the bug User cannot use the has_tag function from an Ability Container because ability_container.gd doesn't have that function. It throws a runtime error when attempting to use it.

To Reproduce

  1. Add an Ability Container to a CharacterBody2D or CharacterBody3D.
  2. Add some tags to the Ability Container.
  3. Open the script attached to the character.
  4. Take a reference from the ability container: _@onready var abilitycontainer: AbilityContainer = $AbilityContainer
  5. Try to use the function has_tag from the Ability Container --> _if not ability_container.hastag("dead"):

Expected behavior The _hastag function should return true or false if the tag is contained in the tags of the specified Ability in the Ability Container.

Screenshots image

image

Desktop (please complete the following information):

Additional context Thank you for developing the addon :) I found this issue following the tutorial. I don't know if the has_tag function should be added to the ability_container.gd file or if I should use the has_some_tags function from ability.gd.

OctoD commented 1 year ago

This bug is due to my incomplete testing. I'll fix in a matter of minutes, thank you for reporting and sorry for the inconvenience.

OctoD commented 1 year ago

Fixed in upstream, will be available on asset store as soon as Godot's team will review it.

Thank you for reporting!

AntonioJose-OcachoGames commented 1 year ago

Great! And no worries, we are here to help :) Thank you!