search

OctoMap / octomap

An Efficient Probabilistic 3D Mapping Framework Based on Octrees. Contains the main OctoMap library, the viewer octovis, and dynamicEDT3D.
http://octomap.github.io
1.93k stars 657 forks source link

octomap reproducible #278

Open lepalom opened 4 years ago

lepalom commented 4 years ago

We have been working with the Debian package of octomap and we have found that fails in some topics to make it reproducible.

We have not found where exactly comes from but I have the suspicious that it comes from #define OCTOMAP_ERROR and OCTOMAP_WARNING because it prints some arguments and probably from which function path is called.

So, that functions can be safely disables or change to not print any path?

Also, in the stalic-lib of octomap libray the build path is hardcoded.

OTOH, we have made some improvements about Multiarch that maybe can be useful for the project.

jnumm commented 4 years ago

OTOH, we have made some improvements about Multiarch that maybe can be useful for the project.

For the record, I just sent PR #279 that is based on the multiarch patch I made for the Debian package.

ahornung commented 4 years ago

@lepalom , do you have any additional changes to request in ordethe buildr to make octomap reproducible? Along with PR #279 there were some changes to the build system recently.

I don't see any paths for the warning / error macros in https://github.com/OctoMap/octomap/blob/devel/octomap/include/octomap/octomap_types.h.

Could it be the unit test macros in https://github.com/OctoMap/octomap/blob/devel/octomap/src/testing/testing.h?

lepalom commented 4 years ago

@ahornung I don't have any more changes. I can prepare a new version and try. Let me do it in some days.