search

OctoMap / octomap_rviz_plugins

RViz display plugins for visualizing octomap messages in ROS
http://ros.org/wiki/octomap_rviz_plugins
89 stars 63 forks source link

use automoc feature of CMake #34

Closed simonschmeisser closed 3 years ago

simonschmeisser commented 5 years ago

This small clean-up made octomap_rviz_plugins build again on our CI on melodic

About the CMake version required: I think it was previously too low, the way you include Qt5 is actually only available since 2.8.11, you had to add qt5_use_module before which is now deprecated. automoc feature would have been available since 2.8.6 actually

wxmerkt commented 3 years ago

Hi @simonschmeisser, thank you for this PR. Does the latest kinetic-devel build on your CI? Or should we go ahead with merging this PR? Many thanks, Wolfgang

simonschmeisser commented 3 years ago

I was just curious what that "resolve conflicts" button does, will do a rebase instead

I quickly took a look at our CI setup but we seem to be using the released melodic packages for some while now.

Still this simplifies the CMake code which is always a good thing to do, right?

wxmerkt commented 3 years ago

Thank you :-) Since CI passes all the way back to kinetic happy to merge