search

OctoNezd / oldlander

WebExt for to make old reddit more usable on phone
MIT License
142 stars 6 forks source link

Caption does not show up on image posts with caption #114

Closed KompaktiLevy closed 5 months ago

KompaktiLevy commented 7 months ago

Describe the bug Posts that have an image and a caption should show the caption when clicked on, but it is not shown on oldlander. There seemingly is no way to tell if an image post has a caption or not.

To Reproduce Steps to reproduce the behavior:

  1. Go to any image post with a caption with oldlander disabled. Example post
  2. Observe caption - the example post should have a caption at the bottom which reads the following:

If my music is 24 bit 192 khz , what would this do to the music then? Would it just play at 24 bit 192 or would it upscale to 32 bit 384 khz? Im confused at what it does. Just confused on how it encodes the music if we dont even have that on a consumer level.

(Screenshot below)

  1. Enable oldlander and refresh the page
  2. The caption is gone

(Screenshot below)

Expected behavior The caption should not be gone

Screenshots Observe the caption Notice the caption at the bottom

Where is it? The caption is gone. (Screenshot taken on desktop, but it's the same on mobile. I don't use this on desktop.)

Desktop:

Smartphone:

Reddit page where bug can be easily reproduced

Same as example post linked before Another one Another one

Additional context This is a very major problem on some subreddits. Perhaps I'm just missing where to find the caption, but I have yet to find it on any post.

OctoNezd commented 7 months ago

IIRC the caption is displayed as part of expando, and oldlander removes expandos. I will try to make it keep the caption.