search

OctoPrint / OctoPrint-FileCheck

Checks for common issues in uploaded files
GNU Affero General Public License v3.0
8 stars 2 forks source link

Plugin wrongly detects hotwords inside GCODE comments #1

Closed foosel closed 4 years ago

foosel commented 4 years ago

Example of a false positive:

; start_gcode = G28 ; home all axes\nG1 Z5 F5000 ; lift nozzle\nG1 X1 F{travel_speed} ; Lifts the nozzle at speed {travel_speed}

Plugin must only match things like {travel_speed} outside of comments.

See https://community.octoprint.org/t/disable-travel-speed-notice/22815/7?u=foosel

thirstyice commented 3 years ago

After updating, it now gives me a false positive on this file: Filament switch holder.gcode.txt

Doing a ctrl-f, the only two instances of "travel" in the file are both in the comments at the end.

foosel commented 3 years ago

I cannot reproduce this against the current version (2020.8.7). The provided file uploads without any warnings.

Can you please share your octoprint.log?

thirstyice commented 3 years ago

I can't replicate it anymore either. 🤷