OctoPrint / OctoPrint-FirmwareUpdater

OctoPrint plugin for flashing pre-compiled firmware images to a 3D printer.
https://plugins.octoprint.org/plugins/firmwareupdater/
GNU Affero General Public License v3.0
353 stars 78 forks source link

LONG_FILENAME_WRITE_SUPPORT support #315

Closed gryzlov closed 1 year ago

gryzlov commented 2 years ago

Please, add LONG_FILENAME_WRITE_SUPPORT for FB Reborn updating

benlye commented 2 years ago

Not 100% sure what you need me to do - just allow long file names in the custom file name option? I don't know if the underlying MarlinBFT protocol will accept them, and that is outside of my control.

gryzlov commented 2 years ago

Yes, can you change regexp to support long file names?

benlye commented 2 years ago

Yes, I can do that. In the meantime, if you set the custom filename option to anything other than firmware.bin the setting will be added to OctoPrint's YAML configuration file, where you can then manually change it to anything you like. You just won't be able to edit it in the UI anymore.

gryzlov commented 2 years ago

Already tried, but get "The target filename is invalid. Filename must be 8dot3 format." error message

gryzlov commented 2 years ago

I removed the code

if (self.getProfileSetting("flash_method") == "marlinbft" && self.getProfileSetting("marlinbft_use_custom_filename") && !self.checkMarlinBftCustomFileName()) {
                 alert = gettext("The target filename is invalid. Filename must be 8dot3 format.");
             }

and i can confirm that long names (in my case - Robin_nano35.bin) are supported and the firmware is successfully updated.

benlye commented 2 years ago

Glad you figured it out, but lets keep this open until I've had a chance to add this option.

O1Wcreations commented 2 years ago

how do i go about updating my ender 6, bother the firmware and the cr touch firmware? not sure if im suppose to use a flash method or not and, just flash the file to the serial port?

benlye commented 2 years ago

how do i go about updating my ender 6, bother the firmware and the cr touch firmware? not sure if im suppose to use a flash method or not and, just flash the file to the serial port?

I haven't got a clue - I don't have the board. Your best bet is to find a user group for your printer and ask there.

benlye commented 2 years ago

Will be addressed in 1.14.0 (available in the devel branch for testing now).

jneilliii commented 1 year ago

Should probably update the UI side of things so it doesn't appear as error when specifying long filename and Cap:LFN_WRITE:1 in capabilities report. I just tested the latest beta version and the process worked flawlessly for me now. Thanks so much for integrating this change.

github-actions[bot] commented 1 year ago

This issue has been automatically locked because there was no further activity after it was closed. Please open a new issue for any related problems.