search

OctoPrint / OctoPrint-FirmwareUpdater

OctoPrint plugin for flashing pre-compiled firmware images to a 3D printer.
https://plugins.octoprint.org/plugins/firmwareupdater/
GNU Affero General Public License v3.0
353 stars 78 forks source link

MarlinBFT and probably all methods broken with OctoPrint 1.9.0rc2 #341

Closed The-EG closed 1 year ago

The-EG commented 1 year ago

Hardware Setup Ender 3 Pro with an BTT Octopus v1.1

Describe the problem Flashing is broken when using MarlinBFT method on OctoPrint 1.9.0rc2. After selecting the bin file and pressing 'Flash From File' the progress bar displays "Flashing Firmware" and nothing happens.

The browser console shows a 400 (BAD REQUEST) error for the /plugin/firmwareupdater/flash url.

There are no errors in the octoprint.log (attached anyway).

Log Files

octoprint.log

Additional context Issue caused by changes in latest OctoPrint release candidate version.

benlye commented 1 year ago

Just want to set expectations - I'm travelling for work and probably won't be able to look into this for at least a week.

benlye commented 1 year ago

Could you try the devel version of the plugin?

The-EG commented 1 year ago

Could you try the devel version of the plugin?

Same result with version 1.14.0b2.

benlye commented 1 year ago

I just got to give this a try. Interesting results...

My installation already had plugin v1.14.0b2 and after updating to OctoPrint v1.9.0rc2 I had no problems flashing the firmware. I downgraded my plugin to v1.13.3 and got the 400 error, I then upgraded to v1.14.0b2 and I still get the 400 error.

This is going to be fun.

The-EG commented 1 year ago

You can reproduce it at least, I'll take it!

I did poke around a bit, it doesn't appear to be even making it to the /flash route.

benlye commented 1 year ago

I think I have the fix for this - please test v1.14.0b3 from the plugin's Development branch.

benlye commented 1 year ago

The solution was actually provided in #323 - all I had to do was merge the PR. Thanks, @arekm.

The-EG commented 1 year ago

Great, I'll take a look this evening.

The-EG commented 1 year ago

Confirmed, 1.14.0b3 resolves this for me on OctoPrint 1.9.0rc2.

github-actions[bot] commented 1 year ago

This issue has been automatically locked because there was no further activity after it was closed. Please open a new issue for any related problems.