search

OctoPrint / octoprint-docker

The dockerized snappy web interface for your 3D printer!
GNU General Public License v3.0
474 stars 224 forks source link

[BUG] `undefined` tag is present on Dockerhub #257

Open davidzwa opened 1 year ago

davidzwa commented 1 year ago

Describe the bug Somehow the tag undefined is pushed with the same layers as bleeding is tagged with. Maybe a workflow bug causes this label to be tagged

To Reproduce Steps to reproduce the behavior:

  1. Visit dockerhub: https://hub.docker.com/layers/octoprint/octoprint/undefined/images/sha256-cd7fede720a0fdf91989939a38c2e604c991eaa81da6353c8367a168489b48ce?context=explore
  2. Find the undefined tag being present

Expected behavior Would not expect this tag

davidzwa commented 1 year ago

I believe not adding a tag_name to the tagging strategy causes this: https://github.com/HackerHappyHour/tagging-strategy#inputs

Check the show docker tags step in my repo: https://github.com/fdm-monster/fdm-monster/actions/runs/4953172047/jobs/8860357559 I've mitigated the undefined tag.

However this one still has the undefined tag: https://github.com/fdm-monster/fdm-monster/actions/runs/4953158427/jobs/8860330428