OctoPrint / plugins.octoprint.org

Sources of the OctoPrint Plugin Repository
https://plugins.octoprint.org
133 stars 341 forks source link

[Abandoned Plugin] TouchUI #1126

Open roblandry opened 1 year ago

roblandry commented 1 year ago

Which Plugin?

https://plugins.octoprint.org/plugins/touchui/

Link to ticket on plugin's issue tracker confirming abandonment

https://github.com/BillyBlaze/OctoPrint-TouchUI/issues/535

Is there someone open to adopting it?

No response

wwian commented 1 year ago

sad face. I still use this app with my prints.

imjosecampos commented 1 year ago

What’s the process to take this over? Fork and re-submit?

jneilliii commented 1 year ago

Fork, address any outstanding major issues relative to compatibility, etc. bump version and submit PR to redirect the update checks. A good example can be found here of such a PR.

imjosecampos commented 1 year ago

Sounds good, will install and check the issues to see how much work may be involved and report back.

vexofp commented 1 year ago

Probably the biggest issue is an incompatibility with Octoprint 1.8.0+. See https://github.com/BillyBlaze/OctoPrint-TouchUI/issues/532 for more info.

There is a link in there to a branch I made and have been using locally that fixed that problem, but I was never entirely happy with it because it broke backwards compatibility with older Octoprint versions. Maybe that is less of a problem now, since 1.8.0 has been out for awhile now? Either way, hopefully it helps!

JohnathonMohr commented 1 year ago

I've been wondering what happened to the temp graph. 😅

Well, if the plugin transfers ownership, that would provide a convenient time to shift compatibility to 1.8.0+. Just my 2 cents.

sfarkhan commented 1 year ago

I use TouchUI as well. I would be up to Patreon someone to take over. It's a popular plugin

TheNore commented 1 year ago

Has there been any update on this? I use this on all of my printers, I would gladly donate to whoever took this over, its a great Plugin!! It would be a shame to loose it.

jneilliii commented 1 year ago

but I was never entirely happy with it because it broke backwards compatibility with older Octoprint versions

You could do a copy of the file and conditionally load the different file based on OctoPrint version. Here's an example of where I've used this.

https://github.com/jneilliii/OctoPrint-TPLinkSmartplug/blob/27d265aadf164f2f2aebad99ef64874af029d869/octoprint_tplinksmartplug/__init__.py#L337

Also, it's always better to utilize id css selector if at all possible, just not sure without looking directly at it if that's available here or not.

Thierry-Myron commented 1 year ago

So sad... Still using on 10.1 touchscreen :(

Unn4m3DD commented 1 year ago

I'm considering taking a look at the plugin, fixing the graph, and maybe some quality-of-life updates, just asking here if someone else is already on it so that we don't duplicate our efforts

imjosecampos commented 1 year ago

Go for it. I was going to but work picked up and this fell off my plate

Unn4m3DD commented 1 year ago

Well, I have it sorted out. I've created a fork with the changes, can someone help me with how to make the update reach octoprints repositories? https://github.com/Unn4m3DD/OctoPrint-TouchUI image

vexofp commented 1 year ago

@Unn4m3DD , I think the legend and temperature values at the bottom there still look messed up. They should look like this: image

Please feel free to steal from https://github.com/BillyBlaze/OctoPrint-TouchUI/compare/master...vexofp:532-temp-graph-1.8.x (if helpful)!

Unn4m3DD commented 1 year ago

I thought those bars were sliders xD I managed to get to this, should be close enough

image
Unn4m3DD commented 1 year ago

Heyy, I have had the PR opened for some time and I'm wondering if I did it in the correct way. @vexofp, you seem to know your way around the octoprint community, any chance you might be able to help me understand this?

jneilliii commented 1 year ago

If you want to adopt the plugin it's just a matter of submitting a PR here that configures the correct update check overlays, the plugin listing data adding you as an author and a bumped version with release on your fork of the plugin. Here is an example of a completed adoption PR to see what I mean.

https://github.com/OctoPrint/plugins.octoprint.org/pull/1157/files

ThatMattCraig commented 1 year ago

I'll take this over. Ill try my best to keep it running for now

pzwe2020 commented 1 year ago

My friend and i would love to transform this project and fix it. We will work our hardest on keeping it up. We just need someone to convert everything to python! I am new to get hub, and need to know how to take over the project.

pzwe2020 commented 1 year ago

*Github

Mbayazeed commented 1 year ago

can't get a cam stream either !!

devildant commented 1 year ago

Good morning, unfortunately I don't have time to resume this plugin, however I made a fix for the webcam on my fork if you want: https://github.com/devildant/OctoPrint-TouchUI

just download the master branch as zip, and install manually inside octoprint

devildant commented 1 year ago

Note: I applied the fix from @Unn4m3DD + fix temp graph settings + fix the SD card symbol in the files section

devildant commented 1 year ago

image

image

image

Mbayazeed commented 1 year ago

That worked perfectly.

Thanks

Kindest regards .

Sent from BlueMailhttps://bluemail.me On Jun 22, 2023, at 9:16 PM, devildant @.**@.>> wrote:

Good morning, unfortunately I don't have time to resume this plugin, however I made a fix for the webcam on my fork if you want: https://github.com/devildant/OctoPrint-TouchUI

just download the master branch as zip, and install manually inside octoprint

— Reply to this email directly, view it on GitHubhttps://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1603190065, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUXU4NMK6UKY4PYHTSVVYVLXMSKZHANCNFSM6AAAAAASRKUQ4I. You are receiving this because you commented.Message ID: @.***>

chuwy5 commented 1 year ago

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

devildant commented 1 year ago

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

at the moment there is no one to take over, i just made patches on my branch to fix the problems on the latest version of octoprint. if you want to resume the project, go go :), it will please a lot of people

pzwe2020 commented 1 year ago

I have been working on trying to figure out the code and I just can get it. Hopefully we can find someone else. Sorry

On August 5, 2023, at 12:33 PM, chuwy5 @.***> wrote:

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666587788", "url": "https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666587788", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

chuwy5 commented 1 year ago

no worries. my thought is to find a group of people that can work on it. unless i can figure it out and start maintaining it. but im down to work on it with others

On Sat, Aug 5, 2023 at 2:12 PM pzwe2020 @.***> wrote:

I have been working on trying to figure out the code and I just can get it. Hopefully we can find someone else. Sorry

On August 5, 2023, at 12:33 PM, chuwy5 @.***> wrote:

is someone maintaining it? if not depending on the code I might be willing to tip my hat in to atempt to keep it going

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": " https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666587788", "url": " https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666587788", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "<a href="https://github.com">https://github.com" } } ]

— Reply to this email directly, view it on GitHub https://github.com/OctoPrint/plugins.octoprint.org/issues/1126#issuecomment-1666608079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISY7S2BIO6GKI4PVDW5S23XT2ZL7ANCNFSM6AAAAAASRKUQ4I . You are receiving this because you commented.Message ID: @.***>

JayroJones commented 1 year ago

Jesus fucking christ, the plugin STILL works fine, and I'm tired of the UI nagging me to remove it because it's "abandoned" by it's creator. (Thanks for that, douche.) How do I get it to stop nagging my system, even-though I always hit "Mark as read."? The nag is annoying as fuck to deal with, but the plugin is too useful to get rid of.

cp2004 commented 1 year ago

@JayroJones - I suggest you choose a different tone so that you come across as a reasonable human being. Please check https://octoprint.org/conduct/.

Marking as read sets a cookie so the notification doesn't show again. If you're having trouble with this, I'd suggest politely trying to seek help on the community forums with appropriate gratitude for anyone who now decides to help you, and remember first impressions count.

K1Printing commented 10 months ago

If someone adopts this plugin and continues it's maintenance I'd be happy to chip in via patreon or something like that, I would take a crack at it, but I don't have the time or resources to learn programming at this given moment.

heinzight commented 4 weeks ago

Help please... I installed this but now I don't want it and there is no 'wrench' to get to be able to uninstall it. How do I uninstall it, please.

jneilliii commented 4 weeks ago

Try http://octopi.local/recovery then restart in safe mode and then you should be able to remove the plugin.

heinzight commented 3 weeks ago

Yes, that worked although I wasn't sure what or where to do the recovery. So it makes me wonder why this plug-in was not on the Blacklist if it's not maintained or at least the warning before not after install.

It seems that install/uninstall wiped out my login credentials (??) to the Pi 4B. I cannot get into the Pi from my computer. I took very careful notes in installing Octopi but it will not acept my username nor password. I can no longer see my files. I can't get into Octopi.org either (that one I do not have notes, long ago when I had a Pi3B.

heinzight commented 3 weeks ago

Thank you Gina!