Support `byte[]` for String/FixedString - Githubissues

Octonica / ClickHouseClient

ClickHouse .NET Core driver

Apache License 2.0

138 stars 23 forks source link

Support `byte[]` for String/FixedString #63

Closed MaceWindu closed 2 years ago

MaceWindu commented 2 years ago

ClickHouse String/FixedString types store binary data, but provider supports only UTF8 string representation.

Issues with current implementation:

it is not possible to use byte[] values. E.g. BulkCopy will throw ClickHouseHandledException : Unable to cast object of type 'System.Byte[]' to type 'System.String'. ----> System.InvalidCastException : Unable to cast object of type 'System.Byte[]' to type 'System.String
conversion of byte[] to string could lead to data loss. E.g. 0xFF will be 0xEF 0xBF 0xBD after binary->string->binary conversion

MaceWindu commented 2 years ago

Hmm, actually, I think only issue here is that byte[] is not recognized as valid value (see exception above). It is possible to access raw data using GetFieldValue<byte[]>(x) method.