Closed MrDoe closed 6 months ago
Thank you for your PR.
Microsoft.ICU.ICU4C.Runtime
is a an application level level dependency. Thus, ClickHouseClient itself should not have a reference to this package;[MSBuild]::IsOSPlatform('Windows')
checks an OS of a build machine, not the target runtime;netcoreapp3.1
, net6.0
, net8.0
are still supported;For the above reasons, I can't accept your pull request, except for the typo fix.
Okay, never mind! Meanwhile I've found more issues with DateTime64 columns, so I switched over using NodaTime for handling dates in my fork, because the .NET functions are faulty when converting DateTimeOffsets before 1970 (I need this for birth dates) from UTC to a time zone with DST. Please take a look at my newest pull request which fixes that issue.