Remove unnecessary initialization of ILog from calls to LogProvider.GetLogger("Halibut")

[nathanwoctopusdeploy]

Background

This PR changes the way ILog instances are created which are used by the InMemoryConnectionLog to improve a performance issue observed in Halibut.

Snippet of pstacks from a Server process dump showing the issue

Before this change, an ILog would be constructed for every log message that Halibut wanted to write.

After this change, the LogFactory constructs an ILog which is reused for all InMemoryConnectionLogs and so all log messages halibut writes.

Related to https://github.com/OctopusDeploy/Issues/issues/8266

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

• [ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
• [ ] I have considered informing or consulting the right people, according to the ownership map.
• [ ] I have considered appropriate testing for my change.

[nathanwoctopusdeploy]

[sc-56658]

[shortcut-integration[bot]]

This pull request has been linked to Shortcut Story #56658: Halibut fix logging thread pool exhaustion.