OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.

Other

12 stars 44 forks source link

Fix a Task.Delay leak in the PendingRequestQueue #469

Closed nathanwoctopusdeploy closed 1 year ago

nathanwoctopusdeploy commented 1 year ago

Background

Fix a Task.Delay leak in the PendingRequestQueue. In the case where an item arrives before the Task.Dealy completes we will leave the Task.Delay running and leak a timer.

Related to https://github.com/OctopusDeploy/Issues/issues/8266

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.