OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.

Other

12 stars 44 forks source link

Add IStreamFactory to consolidate preping streams for halibut #471

Closed LukeButters closed 1 year ago

LukeButters commented 1 year ago

Background

Adds a StreamFactory which creates streams from TcpClient or websockets in a way that halibut will work with.

[SC-55504]

Related to https://github.com/OctopusDeploy/Issues/issues/8266

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #55504: Verify we have converted everything to sync by testing with a stream that throws on sync methods..