OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.
Other
12 stars 44 forks source link

Fix an issue with tests hanging when waiting for the external binary to exit #473

Closed nathanwoctopusdeploy closed 1 year ago

nathanwoctopusdeploy commented 1 year ago

Background

Fix an issue with tests hanging when waiting for the external binary to exit

When running all the PollingOverWebSocket tests locally, I was able to replicate hanging tests every run/couple of runs. Killing some of the CompatBinaries would normally make the tests continue with a handful of failures.

With the fixes in this PR, I am able to run the full suite of PollingOverWebSocket tests over and over. It's still not perfect and often fails after 6+ runs (run until failure) but it is a lot more stable.

How to review this PR

Quality :heavy_check_mark:

Pre-requisites