OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.
Other
12 stars 44 forks source link

PollingOverWebSocket Test Stability changes #474

Closed nathanwoctopusdeploy closed 1 year ago

nathanwoctopusdeploy commented 1 year ago

Background

Changes to the way the compact binary is started mainly around cancellation and more aggressive cancellation during the startup of tasks.

Fixed a flakey bug where a network error was not classified as a network error

Fixed an issue where we were running the same test multiple times due to the TestCases generating a non-distinct set of tests to run - the issue occurs when versions are redirected for stability which occurs for WebSockets.

Locally I have reached 15 tests runs without a failure!! I haven't been able to get past 6 previously!! May be luck, something locally just works but it's a step towards more stability!!

image

How to review this PR

Quality :heavy_check_mark:

Pre-requisites