OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.

Other

12 stars 44 forks source link

Response cache no longer NPE when response is null #482

Closed LukeButters closed 1 year ago

LukeButters commented 1 year ago

Background

The ResponseCache would throw when given a null response. This can happen so instead just don't cache null responses messages.

Note that the entire Halibut ResponseMessage is null, this has nothing to do with that the RPC call itself returned.

[SC-58477]

Related to https://github.com/OctopusDeploy/Issues/issues/8266

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #58477: Halibut throws NPE in ResponseCache.