OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.

Other

12 stars 44 forks source link

Log exceptions before the queue is reached in a way that makes it easy to determine this is before message exchange. #486

Closed LukeButters closed 1 year ago

LukeButters commented 1 year ago

Background

We log errors from a connection from the time theconnection is created to close to when the queue (so no more IO is being done).

These log messages now come out with events types that make it possible to determine they are during the connecting phase. These events are:

ErrorInInitialisation,
ErrorInIdentify
ClientDenied

Some existing log event types are now commented to make it easy for us to identify which ones to log.

[SC-55402]

Results

Related to https://github.com/OctopusDeploy/Issues/issues/8266

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #55402: Get visibility into polling tentacles connecting to the queue..