OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.

Other

12 stars 44 forks source link

Distinguishing between a connection that was authorized or unauthorized. #496

Closed sburmanoctopus closed 1 year ago

sburmanoctopus commented 1 year ago

[sc-59576]

Background

When observing logs for async Halibut, we found that tentacles with invalid thumbprints were becoming noise in the metrics for connections.

Results

Related to https://github.com/OctopusDeploy/Issues/issues/8266

Before

All connections were being put into metrics in Octopus Server, as we did not know if it was an initial connection, or an authorized connection.

After

We now pass a parameter to the observer stating whether we have successfully authorized.

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #59576: Remove accepted/disconnected connection noise from metrics when unauthenticated due to thumbprint..