OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.
Other
12 stars 44 forks source link

Writing test for usecase where a single tentacle can poll multiple Octopus Servers #497

Closed sburmanoctopus closed 1 year ago

sburmanoctopus commented 1 year ago

[sc-58911]

Background

We need a test for when a single tentacle can poll multiple Octopus Servers.

Results

Related to OctopusDeploy/Issues#8266

Before

There was no test that covered this test case.

After

We now have a test that covers this test case.

I also removed the usage of some of the deprecated Poll methods.

Future Enhancement

At some point in the future, it might be good to split the builder into a client and a server builder. Then a lot of what we did can be made into reusable components.

How to review this PR

To minimise change, we only tested latest client and latest service. If we want to test further, let me know and I can roll the changes made to 'latest' out to the other variants as well.

Quality :heavy_check_mark:

Pre-requisites

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #58911: Halibut Test - Polling Halibut Service connecting to Many Clients.