OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.

Other

12 stars 44 forks source link

Fix flakey tests #499

Closed nathanwoctopusdeploy closed 1 year ago

nathanwoctopusdeploy commented 1 year ago

Background

SucceedsWhenPollingServicePresentsWrongCertificate_ButServiceIsConfiguredToTrustAndAllowConnection
- Moved assertion to a place we can guarantee there is no race condition
ParallelRequestsFixture
- Fixed issue where more tasks than expected are run for previous client parallel tests

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.

nathanwoctopusdeploy commented 1 year ago

[sc-59772]

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #59772: Halibut net48 Tests on various OSs are failing frequently.