OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.

Other

12 stars 44 forks source link

Fix Stream CopyAndReportProgress synchronously waiting for a Task to complete #501

Closed sburmanoctopus closed 1 year ago

sburmanoctopus commented 1 year ago

Background

CopyAndReportProgressAsync was calling sync methods. This has the potential to block a thread (as discovered in this PR) from the same code in Octopus Server.

Results

Related to OctopusDeploy/Issues#8266

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.