Closed acodrington closed 11 months ago
This pull request has been linked to Shortcut Story #56164: Add trace level logging to Halibut which logs to console or file only if the test fails..
We have decided to not migrate to xUnit.
While test framework consistency across Octopus projects would be nice to have, this reason alone doesn't justify the investment.
Background
This PR adds xUnit to Halibut, for the following reasons:
As well as adding the new dependencies, this PR migrates some very simple nUnit tests (
CachingLogFactoryFixture
) to xUnit as a proof of concept.Results
There should be no noticeable differences between test runs before and after this migration. The same tests should be run for each build, and test history in TeamCity should continue uninterrupted when a test is converted to xUnit.
The below screenshot shows the test history for a converted test, showing that the test history is unaffected.
Before
After
How to review this PR
Quality :heavy_check_mark:
Pre-requisites