Sync Halibut had a static class, HalibutLimits with a set of static fields that allowed various settings to be configured by the consumer.
During the Async Halibut work, a new type was introduced, HalibutTimeoutsAndLimits which is passed to the HalibutRuntime and the ServiceEndpoint to allow the limits to be changed per runtime and per endpoint. The main driver for this was to allow individual tests to change limits to force certain test scenarios and do it in a way that didn't impact other tests/could run in parallel.
As Sync Halibut has now been removed, we can remove the Obsolete HalibutLimits
[sc-58528]
How to review this PR
Quality :heavy_check_mark:
Pre-requisites
[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.
Background
Sync Halibut had a static class,
HalibutLimits
with a set of static fields that allowed various settings to be configured by the consumer.During the Async Halibut work, a new type was introduced,
HalibutTimeoutsAndLimits
which is passed to the HalibutRuntime and the ServiceEndpoint to allow the limits to be changed per runtime and per endpoint. The main driver for this was to allow individual tests to change limits to force certain test scenarios and do it in a way that didn't impact other tests/could run in parallel.As Sync Halibut has now been removed, we can remove the Obsolete
HalibutLimits
[sc-58528]
How to review this PR
Quality :heavy_check_mark:
Pre-requisites