OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.
Other
12 stars 44 forks source link

Remove Halibut Limits #521

Closed nathanwoctopusdeploy closed 1 year ago

nathanwoctopusdeploy commented 1 year ago

Background

Sync Halibut had a static class, HalibutLimits with a set of static fields that allowed various settings to be configured by the consumer.

During the Async Halibut work, a new type was introduced, HalibutTimeoutsAndLimits which is passed to the HalibutRuntime and the ServiceEndpoint to allow the limits to be changed per runtime and per endpoint. The main driver for this was to allow individual tests to change limits to force certain test scenarios and do it in a way that didn't impact other tests/could run in parallel.

As Sync Halibut has now been removed, we can remove the Obsolete HalibutLimits

[sc-58528]

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #58528: After 2023.4 - Delete Sync Halibut.