OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.
Other
12 stars 44 forks source link

Add timeouts for auth and identification #550

Closed LukeButters closed 12 months ago

LukeButters commented 12 months ago

Background

[SC-65303]

Adds:

        /// <summary>
        ///    Timeout for read/writes during the the authentication and identification phase of communication.
        ///
        ///    Currently set to 10 minutes as this was the previous value, a value similar to TcpClientHeartbeatTimeout is recommended.
        /// </summary>
        public SendReceiveTimeout TcpClientAuthenticationAndIdentificationTimeouts { get; set; } = new(sendTimeout: TimeSpan.FromMinutes(10), receiveTimeout: TimeSpan.FromMinutes(10));

Which applies during:

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

shortcut-integration[bot] commented 12 months ago

This pull request has been linked to Shortcut Story #65303: Reduce authentication and identification timeouts..