OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.

Other

12 stars 44 forks source link

Fix a bug in cooperative cancellation for Polling Services causing a request to time out to quickly #558

Closed nathanwoctopusdeploy closed 11 months ago

nathanwoctopusdeploy commented 11 months ago

Background

This PR fixes a bug in cooperative cancellation for Polling Requests which cause the transferring request to be cancelled after the PollingRequestQueueTimeout rather than waiting for the PollingRequestMaximumMessageProcessingTimeout

[sc-58429]

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.

shortcut-integration[bot] commented 11 months ago

This pull request has been linked to Shortcut Story #58429: After 2023.4 - Revisit RPC Retries once Sync Halibut is deleted and optimistically/co-operatically cancel RPC calls and Script Execution.