OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.
Other
12 stars 44 forks source link

Remove a race condition from QueueAndWait_Can_Queue_Dequeue_WhenRequestsAreBeingCancelled #589

Closed LukeButters closed 11 months ago

LukeButters commented 11 months ago

Background

[SC-67432]

Sometimes (2 in 1000 runs) this test fails with:

Expected completedTask.Count(x => x != *******) to be less than 400, but found 400.

This might be because:

this means it might be possible to be in a state in which only:

tasks are cancelled!

Thus 400 tasks (or technically even 401 tasks) could have completed successfully. Explaining the to be less than 400, but found 400. error.

The fix is to:

Pre-requisites

shortcut-integration[bot] commented 11 months ago

This pull request has been linked to Shortcut Story #67432: Flakey test - QueueAndWait_Can_Queue_Dequeue_WhenRequestsAreBeingCancelled.