OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.

Other

12 stars 44 forks source link

Retry assertion to resolve timing issues in MaximumActiveTcpConnectionsFixture test #601

Closed APErebus closed 7 months ago

APErebus commented 7 months ago

Background

We've noticed that this test can be flaky. It seems that the assertion sometimes runs just before the logs are populated. To resolve this, we now put the assertion in Wait.UntilActionSucceeds to do some retry for up to 30s.

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[x] I have considered informing or consulting the right people, according to the ownership map.
[x] I have considered appropriate testing for my change.