Auto-deploy with large numbers of machines throws "too many parameters" exception

[MarkSiedle]

If you have a project trigger setup that fires for a large number of machines, one of the MachineFinder queries maxes out on parameters and throws an exception.

System.Data.SqlClient.SqlException (0x80131904): The incoming request has too many parameters. The server supports a maximum of 2100 parameters. Reduce the number of parameters and resend the request.
...
   at Octopus.Server.Schedules.AutoDeployments.MachineFinder.GetMachinesThatHaveTriggered(Nullable`1 fromDate, DateTimeOffset toDate) in Z:\BuildAgent\work\cd33152532ae115f\source\Octopus.Server\Schedules\AutoDeployments\MachineFinder.cs:line 52

Important Note This is occurring because of a long-running deployment completing (e.g. a deploy that ran for weeks, possibly due to waiting on manual interventions etc). Auto-deploy then triggers and looks for all events that have occurred since the deployment began, which results in thousands of events, which then explodes the query with too many parameters.

Two things need to be fixed:

• Our machine query should be able to handle > 2100 machines.
• Auto-deploy should use the last-successful-auto-deploy date when sourcing for events if possible, rather than just the start date of the deployment (to cut down on a potentially massive query that is unnecessary).

Steps to reproduce

• Setup your instance with thousands of machines (> 2100) with the role "app-server"
• Setup a project trigger that will fire for all "web-server" machines
• Run a script via the API/OctopusClient that updates all machines to the "web-server" role

Note to dev reviewing: It may help to temporarily disable the auto-deploy scheduler while you create the >2100 machines locally, then re-launch with the schedule enabled again, so it processes all these machines at one time. Otherwise the schedule may start running before you have > 2100 machines to process at once.

^ This should force all machines to be included in the auto-deploy trigger and throw the exception

Source: http://help.octopusdeploy.com/discussions/problems/47932

[octoreleasebot]

Release Note: Auto-deploy performance improvements to better handle long-running deployments (you can also deploy to more than 2100 machines now)

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.