OctopusDeploy / Issues

| Public | Bug reports and known issues for Octopus Deploy and all related tools
https://octopus.com
161 stars 20 forks source link

User with EventView for project cannot see deployment process change audit records #3055

Closed MJRichardson closed 5 years ago

MJRichardson commented 7 years ago

As reported here: http://help.octopusdeploy.com/discussions/problems/50376

In the ListEventsResponder we do this:

var rule = new ScopedPermissionRequiredRule(typeof(Event), Permission.EventView);
...
rule.Customize(query) ...

This modifies the query to append SQL Where clauses which restrict Events to those with appropriate values for ProjectId and EnvironmentId. The DeploymentProcessModified event does have values for EnvironmentId, and so is being excluded.

This is tricky, as there are some cases where absence of a value for a scope means permission should be denied. In this case, it seems it should be granted.

Two possible options:

Related Slack conversation: https://octopusdeploy.slack.com/archives/help-me/p1483930666000058

SeijiSuenaga commented 7 years ago

This bug affects variable and tenant changes as well.

Has there been any progress on this issue since January?

MJRichardson commented 7 years ago

User with EventView for project cannot see deployment process change audit records

NickJosevski commented 5 years ago

Release Notes: Fix for inconsistencies in EventView permission calculations.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.