Prerequisites

[x] I have verified the problem exists in the latest version
[x] I have searched open and closed issues to make sure it isn't already reported
[x] I have written a descriptive issue title
[x] I have linked the original source of this report
[x] I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

Updating calamari on all machines incorrectly reports that no machines need updates. The client passes MachineIds: [], which is incorrectly interpreted as no machines, and reported as No machines needs Calamari upgraded.

On investigating, it seems that the permissions check dont take into account this "no machines specified" == "all machines" in the ExtractDataFromModel method - this should be fixed at the same time as this issue.

What I expected to happen

Steps to reproduce

$endpoint = new-object Octopus.Client.OctopusServerEndpoint "http://localhost:8065"
$repository = new-object Octopus.Client.OctopusRepository $endpoint
$LoginObj = New-Object Octopus.Client.Model.LoginCommand 
$LoginObj.Username = "admin"
$LoginObj.Password = "Password01!"

$repository.Users.SignIn($LoginObj)

$task = $repository.Tasks.ExecuteCalamariUpdate();

Affected versions

Octopus Server:

Workarounds

Pass the machine ids when creating the task

Links

source: internally reported

OctopusDeploy / Issues

Updating calamari on all machines incorrectly reports no machines need updates #5276